[Bug 512270] Review Request: quitcount - A tool for people who quit smoking

Sat Jul 18 11:55:27 UTC 2009

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=512270

--- Comment #3 from Christoph Wickert <fedora at christoph-wickert.de>  2009-07-18 07:55:26 EDT ---
(In reply to comment #2)
> The license should be GPLv3+, sorry.  

Yeah, I already noticed that during review.

REVIEW for 415304ba78f2eb27404808854509c185  quitcount-1.4.1-1.fc11.src.rpm

OK - MUST: rpmlint must be run on every package. The output should be posted in
the review:
$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/quitcount-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

OK - MUST: The package is named according to the Package Naming Guidelines.
OK - MUST: The spec file name matches the base package %{name}, in the format
%{name}.spec.
OK - MUST: The package meets the Packaging Guidelines.
OK - MUST: The package is licensed with a Fedora approved license and meets the
Licensing Guidelines: GPLv3+
FAIL - MUST: The License field in the package spec file does not match the
actual license: Sources and COPYING are GPLv3+, but license tag is BDS.
OK - MUST: The license file from the source package is included in %doc.
OK - MUST: The spec file is in American English.
OK - MUST: The spec file for the package is legible.
OK - MUST: The sources used to build the package match the upstream source by
MD5 6b49eab7f34155d740e7404a09ba6d0d
OK - MUST: The package successfully compiles and builds into binary rpms on
x86_64
N/A - MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
OK - MUST: All build dependencies are listed in BuildRequires.
OK - MUST: The spec file handles locales properly with the %find_lang macro.
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
N/A - MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package.
OK - MUST: The package owns all directories that it creates.
OK - MUST: The package does not contain any duplicate files in the %files
listing.
OK - MUST: Permissions on files are set properly. Every %files section includes
a %defattr(...) line.
OK - MUST: The package has a %clean section, which contains rm -rf
%{buildroot}.
OK - MUST: The package consistently uses macros, as described in the macros
section of Packaging Guidelines.
OK - MUST: The package contains code, or permissable content.
N/A - MUST: Large documentation files should go in a -doc subpackage.
OK - MUST: Files included as %doc do not affect the runtime of the application.
N/A - MUST: Header files must be in a -devel package.
N/A - MUST: Static libraries must be in a -static package.
N/A - MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.
N/A - MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
N/A - MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency.
OK - MUST: The package does not contain any .la libtool archives.
OK - MUST: The package contains a GUI application and includes a
%{name}.desktop file, and that file is properly installed with
desktop-file-install in the %install section.
OK - MUST: The packages does not own files or directories already owned by
other packages.
OK - MUST: At the beginning of %install, the package runs rm -rf %{buildroot}.
OK - MUST: All filenames in rpm packages are valid UTF-8.

SHOULD Items:
N/A - SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: The the package builds in mock.
OK - SHOULD: The package should compile and build into binary rpms on all
supported architectures.
OK - SHOULD: The package functions as described, however it has some functional
some limitations: You cannot smoke more than 100 cigaretts a day. :)
N/A - SHOULD: If scriptlets are used, those scriptlets must be sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD: The placement of pkgconfig(.pc) files depends on their usecase,
and this is usually for development purposes, so should be placed in a -devel
pkg.
N/A - SHOULD: If the package has file dependencies outside of /etc, /bin,
/sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the
file instead of the file itself.

Other items:
OK - Timestamps are preserved
OK - Latest version packaged
OK - ${RPM_OPT_FLAGS} are honored

Issues:
License tag wrong, see above

Icon in the launcher is missing because Icon cache is not being updated, see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

What's the use of:
mv %{buildroot}/etc/xdg/autostart/%{name}.desktop
%{buildroot}/%{_datadir}/applications/
desktop-file-install                                        \
    --dir=%{buildroot}%{_datadir}/applications              \
    %{buildroot}/%{_datadir}/applications/%{name}.desktop

Note you are hardcoding /etc here. Why not simply use: 
desktop-file-install                                        \
    --dir=%{buildroot}%{_datadir}/applications              \
    --delete-original                                       \
    %{buildroot}/%{_sysconfdir}/xdg/autostart/%{name}.desktop

IMO the package should be autostarted, because the tray icon is a reminder to
actually quit smoking. Remove "--delete-original" and you are done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.