[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #9 from Axel Thimm <axel.thimm at atrpms.net>  2009-07-19 06:29:59 EDT ---
(In reply to bug 439772 comment #21)
> I think the choice to make minilzo a shared lib is probably not really what the
> authors of lzo or the consumer software intended. The idea was to have a one
> file statically swallowed in build procedures w/o any further ties to the lzo
> project. Now if the API/ABI of minilzo changes the other software is dependent
> on being patched up to work with it.
> 
> Just looking at how this issue is holding up a useful package for 6 months (!)
> and the amount of patching one needs to remove the internal minilzo. I hardly
> think that upstream will accept any of this patching (did anyone try to send
> them upstream). Next updates of libvncserver/x11vnc will probably need to
> adjust/extend the minilzo patching again.
> 
> And all that for blindly adhering to guidelines? I'm sure if presented to the
> FPC they would probably ack the use of minilzo as is. Fedora is currently even
> more upstream closer than 6 months before, so chances are that upstream
> proximity will win over other guidelines.
> 
> And yes, I did have a check on how to remove minilzo in x11vnc and just see the
> work involved. Trivial OTOH, but not a small workload to maintain on the other.  

(In reply to comment #3)
> > And, if I am not mistaken, your package suffers from the same problem as
> > described under https://bugzilla.redhat.com/show_bug.cgi?id=439772, it is
> > built using the internal minilzo instead of the ones made available by
> > lzo-minilzo  
> Hmmmm. Yes, you are right again. I'm fix it. Now used system variant.

No, please don't. Check the discussion in the old bug. The embedded minilzo is
a feature, not a bug. If you don't want the embedded *minilzo*, then you should
use lzo, not the forced-shared-minilzo package.

minilzo is by upstream's definition for embedded, statically linked
applications.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.