[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #16 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-07-21 04:49:02 EDT ---
(In reply to comment #15)
> Although technically your solution is correct, I think that performance wise it
> is better to use:
Yes, I known how make conditional BR, but it is what I try avoid there. And
please note, this is only performance wise on build stage it is not related in
any user installation of package.

> > Now it built successful:
> > http://koji.fedoraproject.org/koji/taskinfo?taskID=1487807
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1487918 (F11)
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1487913 (rawhide)
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1487923 (EL-5)
> 
> Mind that EL-5 build fails because of the lzo dependency (
> http://koji.fedoraproject.org/koji/getfile?taskID=1487925&name=build.log ):
>     ultra.c:11:21: error: minilzo.h: No such file or directory
>     ultra.c: In function 'rfbSendOneRectEncodingUltra':  

Epel lzo do not contain minilzo variant of package:

$ rpm -qpl
http://download.fedora.redhat.com/pub/epel/5/i386/lzo-devel-2.02-2.el5.1.i386.rpm
/usr/include/lzo
/usr/include/lzo/lzo1.h
/usr/include/lzo/lzo1a.h
/usr/include/lzo/lzo1b.h
/usr/include/lzo/lzo1c.h
/usr/include/lzo/lzo1f.h
/usr/include/lzo/lzo1x.h
/usr/include/lzo/lzo1y.h
/usr/include/lzo/lzo1z.h
/usr/include/lzo/lzo2a.h
/usr/include/lzo/lzo_asm.h
/usr/include/lzo/lzoconf.h
/usr/include/lzo/lzodefs.h
/usr/include/lzo/lzoutil.h
/usr/lib/liblzo2.so
/usr/share/doc/lzo-devel-2.02
/usr/share/doc/lzo-devel-2.02/LZO.FAQ
/usr/share/doc/lzo-devel-2.02/LZO.TXT
/usr/share/doc/lzo-devel-2.02/LZOAPI.TXT

So, should we try patch it use lzo instead?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.