[Bug 507958] Review Request: eclipse-rse - Eclipse Remote System Explorer framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507958





--- Comment #6 from Jeff Johnston <jjohnstn at redhat.com>  2009-07-21 13:13:06 EDT ---
(In reply to comment #5)
> A few more minor things:
> 
> - you have ${_jvmdir} and %{_jvmdir}

fixed to use %{_jvmdir}

> - this is weird:  $RPM_BUILD_ROOT%{install_loc} ... please use
> %{buildroot}%{install_loc}.  In fact, please s/$RPM_BUILD_ROOT/%{buildroot}/g
> in the whole file

done

> - do what Alex suggests for the doc files
> 

done

> Thanks for dealing with the qualifier situation.  

Replaced files at:

Spec URL: ftp://sources.redhat.com/pub/newlib/eclipse-rse.spec
SRPM URL: ftp://sources.redhat.com/pub/newlib/eclipse-rse-3.0.3-1.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.