[Bug 502556] Review Request: lamson - A Python SMTP server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502556


Mads Kiilerich <mads at kiilerich.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mads at kiilerich.com




--- Comment #1 from Mads Kiilerich <mads at kiilerich.com>  2009-07-21 15:51:29 EDT ---
This seems to be an interesting project - nice to have it packaged for Fedora.
I will look forward to play with it. I have looked briefly at the package.

Upstream tar contains GPLv3 LICENSE file. But PKG-INFO has "License: UNKNOWN"
and I can't find any other references to what role the LICENSE file has - if it
is GPLv3 only or if later versions also can be used. Why are you using the
license tag GPLv3+? Anyway: Upstream should be asked to clarify the license.

Upstream has released 0.9.3 - please base the package on that version. Or
perhaps go directly to one of the 1.0 pre releases where the chances of getting
changes upstreamed are bigger.

The package installs a python library and a management binary. I am not
familiar with lamson (except for quick browsing through the fine
documentation), but using Fedora terminology i would call it an mail
application server framework. The application group you have chosen supports
that. It can easily generate a mail server which can and should be customized,
but that doesn't make it a mail server. It isn't a running server in which you
can create mail applications, but it can create individual "servers" for each
application. I suggest that you make that clearer in the description.

I would expect a mail server to be integrated with Fedora, with for example
init.d script and logging to /var/log, and it should only require minimal
configuration to get up and running. Obviously those who use lamson as a
framework doesn't want that. But perhaps that could be placed in a subpackage?
And perhaps a default mail server in an (other?) subpackage?

Perhaps the main package could contain an init.d scripts which starts the
lamson servers listed in a sysconfig file?

I expect lamson mail servers to have issues with SElinux. Have you tried or any
opinion on that? But again, as long as the lamson package is a framework and
not a server then SElinux isn't its business...

--
reviews/sponsor wanted for tortoisehg on bug 509936

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.