[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #20 from Axel Thimm <axel.thimm at atrpms.net>  2009-07-21 16:11:43 EDT ---
(In reply to comment #13)
> > - would it be an option to use the system's libvncserver library instead of the
> > internal one? (--use-system-libvncserver
> This is very interesting question. I think it is will be "right" solution.
> Additionally it completely solve minilzo problem as I can understand.

This is bug #439979. The shared-minilzo patch there has broken
--use-system-libvncserver. E.g. one guideline kills the other.

If one argues that one needs a shared (mini)lzo, then one needs to continue the
logic and require a shared libvncserver.

(In reply to comment #18)
> > > So, should we try patch it use lzo instead?  
> > Yes, pretty please.  
> Yeh, ok, I'll try do it.  

About a million thanks! And the same applies to libvncserver (actually most of
the lzo calls are in the libvncserver part, if not all). So maybe you want to
fix libvncserver first?

Just for testing, you can build a static-minilzo libvncserver and see whether
--use-system-libvncserver works, and whether there is any minilzo code used
directly anymore by x11vnc. If not, then this part of the review is done and
the shared-lzo patch would need to move completely to libvncserver.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.