[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #22 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-07-21 16:48:31 EDT ---
(In reply to comment #20)> 
> This is bug #439979. The shared-minilzo patch there has broken
> --use-system-libvncserver.
I'll look to it. My patch to cut off minilzo from x11vnc work as expected I
think.

> E.g. one guideline kills the other.
> If one argues that one needs a shared (mini)lzo, then one needs to continue the
> logic and require a shared libvncserver.
About what you speaking? What argues to what? I say what *both* library should
be used as shared system libraries, and at this time work to do that (for
libvncserver now).

> (In reply to comment #18)
> About a million thanks! And the same applies to libvncserver (actually most of
> the lzo calls are in the libvncserver part, if not all). So maybe you want to
> fix libvncserver first?
As I say, off course I'll try do it.

> Just for testing, you can build a static-minilzo libvncserver and see whether
> --use-system-libvncserver works, and whether there is any minilzo code used
> directly anymore by x11vnc. If not, then this part of the review is done and
> the shared-lzo patch would need to move completely to libvncserver.  
In my patch to cutoff minilzo I compleately remove even files of it from
sources before start process. So, it can be linked only with system (mini)lzo
library.
But now, as I want link it with system libvncserver it have not many sense...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.