[Bug 511277] Review Request: comoonics-cluster-py - general cluster library for querying different clusters (used for open-sharedroot)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=511277


Nils Philippsen <nphilipp at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Nils Philippsen <nphilipp at redhat.com>  2009-07-22 04:09:37 EDT ---
Items marked "GOOD" or "PASS" fulfil the guidelines or they don't apply to this
package.
Items marked "CHECK" aren't covered by the guidelines but you should check and
fix them anyway in my opinion.
Items marked "BAD" violate the guidelines in some point and need to be fixed.

- GOOD: rpmlint run on doesn't flag errors/warnings
- GOOD: package name according to guidelines
- GOOD: spec file named properly
- GOOD: package meets packaging guidelines
- GOOD: licensed according to licensing guidelines
- GOOD: license in spec file matches license in package
- GOOD: license shipped as documentation
- GOOD: the spec file is written in American English
- GOOD: the spec file is legible
- GOOD: sources used to build the package match upstream source

--> remember to bump the version if you make changes to the tarball (from now
on at least)

- GOOD: builds in mock for x86_64/Rawhide
- GOOD: all build dependencies listed
- PASS: doesn't ship locale files
- PASS: no libraries shipped
- GOOD: package is not relocatable
- GOOD: all shipped directories owned by package, direct dependency or
filesystem
- GOOD: no duplicates in %files
- GOOD: permissions on files are set properly
- GOOD: package has a %clean section
- GOOD: package uses macros consistently
- GOOD: the package contains code, not content
- PASS: no large documentation files
- GOOD: %doc doesn't affect runtime
- PASS: no header files
- PASS: no static libraries
- PASS: no pkgconfig files
- PASS: no libraries included
- PASS: no devel package
- GOOD: no *.la libtool archives
- PASS: no desktop file
- GOOD: doesn't own files or directories owned by other packages
- GOOD: build root is cleaned at the beginning of %install
- GOOD: all file names are valid UTF-8

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.