[Bug 512674] Review Request: python-iwlib - Python module to interface with iwlib

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512674





--- Comment #1 from Dan Horák <dan at danny.cz>  2009-07-22 04:15:52 EDT ---
formal review is here, see the notes below:

OK* source files match upstream:
     b677495341b777151f993ebddd979e21d9444a23  python-iwlib-0.1.tar.bz2
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK* license is open source-compatible (GPLv2). License text included in
package.
OK* latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
BAD rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
BAD file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- project home page from the URL tag doesn't exist, IMHO you should start a
project on fedorahosted.org, latest version can't be checked
- you should copy the standard GPL header into the iwlib.c source file
- rpmlint complains a bit
python-iwlib.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/iwlib.so 0775
    => should be 0755

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.