[Bug 510788] Review Request: WebShell - Encrypted shell access via web browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510788





--- Comment #2 from Ian Weller <ian at ianweller.org>  2009-07-22 11:47:04 EDT ---
[  OK  ] specfiles match:
  464c9e41ff8ccc3504dd92c43c795907  WebShell.spec
  464c9e41ff8ccc3504dd92c43c795907  WebShell-0.9.6-1.fc11.src/WebShell.spec
[  OK  ] source files match upstream:
  5efa06473bef8dfb2049a15d99b76d8e  WebShell-0.9.6.zip
  5efa06473bef8dfb2049a15d99b76d8e 
WebShell-0.9.6-1.fc11.src/WebShell-0.9.6.zip
[  OK  ] package meets naming and versioning guidelines.
[FAILED] spec is properly named, cleanly written, and uses macros consistently.
  %{buildroot} or $RPM_BUILD_ROOT?
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[FAILED] license is open source-compatible.
  uh www/background.jpg looks fairly familiar to something from OS X, please
check
  also please check with upstream on all artwork and perhaps CSS/JS
[  N/A ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  N/A ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[  N/A ] debuginfo package looks complete.
[  OK  ] rpmlint is silent.
[  OK  ] final provides and requires are sane
[  N/A ] %check is present and all tests pass:
[  N/A ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[FAILED] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  N/A ] no headers.
[  N/A ] no pkgconfig files.
[  N/A ] no libtool .la droppings.
[  N/A ] desktop files valid and installed properly.

Please fix these items

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.