[Bug 510788] Review Request: WebShell - Encrypted shell access via web browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510788


Ian Weller <ian at ianweller.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(chris at tylers.info
                   |                            |)




--- Comment #4 from Ian Weller <ian at ianweller.org>  2009-07-22 12:52:34 EDT ---
(In reply to comment #3)
> > [FAILED] scriptlets match those on ScriptletSnippets page.
> 
> Guidelines say: "SHOULD: If scriptlets are used, those scriptlets must be sane.
> This is vague, and left up to the reviewers judgement to determine sanity." --
> it does not say that ScriptletSnippets are the only acceptable ones.
> 
> This scriptlet seems sane to me, and is similar to what the ssh server package
> does when it generates a host key.

I'd rather see it done as a README.fedora type of instruction or something done
when first running the package. It's somewhat confusing to see when installing
the RPM unless you know exactly what that stuff means.

> > [FAILED] license is open source-compatible.
> >  uh www/background.jpg looks fairly familiar to something from OS X, please
> check
> >  also please check with upstream on all artwork and perhaps CSS/JS
> 
> Checking with upstream.  

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.