[Bug 513069] Review Request: ovirt-server - The oVirt Server is an open cross-platform virtualization management system.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513069





--- Comment #1 from Daniel Berrange <berrange at redhat.com>  2009-07-22 14:16:38 EDT ---
There's a few issues requiring fixes


MUST: rpmlint must be run on every package.

$ rpmlint  ovirt-server-0.100-1.fc12.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

# rpmlint rpmbuild/SPECS/ovirt-server.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

# rpmlint rpmbuild/RPMS/noarch/ovirt-server-0.100-1.fc12.noarch.rpm
ovirt-server.noarch: W: non-standard-uid /var/log/ovirt-server/mongrel.log
ovirt
ovirt-server.noarch: W: non-standard-gid /var/log/ovirt-server/mongrel.log
ovirt
ovirt-server.noarch: E: zero-length /var/log/ovirt-server/mongrel.log
ovirt-server.noarch: W: non-standard-uid /var/log/ovirt-server/db-omatic.log
ovirt
ovirt-server.noarch: W: non-standard-gid /var/log/ovirt-server/db-omatic.log
ovirt
ovirt-server.noarch: E: zero-length /var/log/ovirt-server/db-omatic.log
ovirt-server.noarch: W: non-standard-uid /var/log/ovirt-server/rails.log ovirt
ovirt-server.noarch: W: non-standard-gid /var/log/ovirt-server/rails.log ovirt
ovirt-server.noarch: E: zero-length /var/log/ovirt-server/rails.log
ovirt-server.noarch: W: non-standard-uid /var/lib/ovirt-server/tmp ovirt
ovirt-server.noarch: W: non-standard-gid /var/lib/ovirt-server/tmp ovirt
ovirt-server.noarch: W: non-standard-uid /var/log/ovirt-server ovirt
ovirt-server.noarch: W: non-standard-gid /var/log/ovirt-server ovirt
ovirt-server.noarch: W: non-standard-uid /var/lib/ovirt-server ovirt
ovirt-server.noarch: W: non-standard-gid /var/lib/ovirt-server ovirt
ovirt-server.noarch: W: non-standard-uid /var/log/ovirt-server/taskomatic.log
ovirt
ovirt-server.noarch: W: non-standard-gid /var/log/ovirt-server/taskomatic.log
ovirt
ovirt-server.noarch: E: zero-length /var/log/ovirt-server/taskomatic.log
ovirt-server.noarch: W: non-standard-uid /var/run/ovirt-server ovirt
ovirt-server.noarch: W: non-standard-gid /var/run/ovirt-server ovirt
1 packages and 0 specfiles checked; 4 errors, 16 warnings.

$ rpmlint  rpmbuild/RPMS/noarch/ovirt-server-installer-0.100-1.fc12.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


FAIL

The zero-length length log files should be marked with '%ghost' to avoid
this RPM lint error.

The non-standard-gid/uid warnings are harmless & can be ignored, though
recommend requesting a static alloction of uid/gid in the 'setup' RPM.


MUST: The package must be named according to the Package Naming Guidelines.

PASS

MUST: The spec file name must match the base package %{name}

PASS

MUST: The package must meet the Packaging Guidelines.

PASS

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines.

PASS

MUST: The License field in the package spec file must match the actual license.

FAIL.

It appears that the files in   com/adobe/serialization/json are BSD licensed
so need to add that as another listed license


MUST: If (and only if) the source package includes the text of the license(s)
in its
      own file, then that file, containing the text of the license(s) for the
package must
      be included in %doc.

PASS

MUST: The spec file must be written in American English.

PASS

MUST: The spec file for the package MUST be legible.

PASS

MUST: The sources used to build the package must match the upstream source

FAIL

The Source:  tag should be using a full URL to upstream sources so that its
possible to verify it.

MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.

PASS on x86_64 f12 rawhide

MUST: If the package does not successfully compile, build or work on an
architecture, 
      then those architectures should be listed in the spec in ExcludeArch.

PASS, noarch so can build anywhere

MUST: All build dependencies must be listed in BuildRequires

PASS

MUST: The spec file MUST handle locales properly

N/A

MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any
      of the dynamic linker's default paths, must call ldconfig in %post and
%postun.

N/A

MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review

N/A

MUST: A package must own all directories that it creates.

PASS

MUST: A package must not contain any duplicate files in the %files listing.

PASS

MUST: Permissions on files must be set properly.

PASS

MUST: Each package must have a %clean section

PASS

MUST: Each package must consistently use macros

FAIL, a few places use $RPM_BUILD_ROOT, while most uses %{buildroot}. SHould
make
them all use %{buildroot}

MUST: The package must contain code, or permissable content

PASS

MUST: Large documentation files should go in a -doc subpackage

N/A

MUST: If a package includes something as %doc, it must not affect the runtime
of the application

PASS

MUST: Header files must be in a -devel package.

N/A

MUST: Static libraries must be in a -static package.

N/A

MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'

N/A

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.

N/A

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency

N/A

MUST: Packages must NOT contain any .la libtool archives

N/A

MUST: Packages containing GUI applications must include a %{name}.desktop file

N/A

MUST: Packages must not own files or directories already owned by other
packages

PASS

MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}

PASS

MUST: All filenames in rpm packages must be valid UTF-8.

PASS

SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.

PASS

SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.

N/A

SHOULD: The reviewer should test that the package builds in mock.

NOT checked.

SHOULD: The package should compile and build into binary rpms on all supported
architectures.

NOT checked

SHOULD: The reviewer should test that the package functions as described.

NOT checked

SHOULD: If scriptlets are used, those scriptlets must be sane.

PASS

SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency.

FAIL - looks like ovirt-server-installer should have a reqiures on the
ovirt-server

SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.

N/A

SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.

N/A

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.