[Bug 469470] Review Request: mausezahn - A fast versatile packet generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469470


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
            Summary|Review Request: mz - A fast |Review Request: mausezahn -
                   |versatile packet generator  |A fast versatile packet
                   |                            |generator
               Flag|                            |fedora-review?




--- Comment #30 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-07-22 14:41:51 EDT ---
Some initial comments:

* Dependency
  - "python-matplotlib" seems to be needed for view_rtp_avg.py, however
    this is installed as a document
    ( i.e. if you install the binary rpm by $ rpm -ivh --excludedocs ,
      this python script is not instaled )
    We usually avoid to add dependency for document files.
    Would you explain why you want to add this dependency?

* make build log more verbose
  - build.log shows
----------------------------------------------------------------
    52  + make -j4
    53  Scanning dependencies of target mz
    54  [ 11%] [ 11%] [ 22%] [ 22%] Building C object
src/CMakeFiles/mz.dir/mz.o
    55  Building C object src/CMakeFiles/mz.dir/layer1.o
    56  Building C object src/CMakeFiles/mz.dir/layer3.o
    57  Building C object src/CMakeFiles/mz.dir/layer2.o
----------------------------------------------------------------
    This output is not useful. For example we cannot check if
    Fedora specific compilation flags are correctly honored
    ( And actually currently this is not correctly honored:
      see below).
    Please add "VERBOSE=1" as a option to make. ref:
    https://fedoraproject.org/wiki/Packaging/cmake#Specfile_Usage

* Fedora specific compilation flags
  https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
  - Actually "make VERBOSE=1" shows Fedora specific compilation
    flags are not correctly honored:
---------------------------------------------------------------
[ 11%] [ 11%] [ 16%] [ 22%] Building C object src/CMakeFiles/mz.dir/layer2.o
cd /builddir/build/BUILD/mz-0.34.6/src && /usr/bin/gcc  
-I/builddir/build/BUILD/mz-0.34.6/. -I/builddir/build/BUILD/mz-0.34.6/..
-I/builddir/build/BUILD/mz-0.34.6   -o CMakeFiles/mz.dir/layer2.o   -c
/builddir/build/BUILD/mz-0.34.6/src/layer2.c
Building C object src/CMakeFiles/mz.dir/mz.o
Building C object src/CMakeFiles/mz.dir/layer1.o
Building C object src/CMakeFiles/mz.dir/layer3.o
cd /builddir/build/BUILD/mz-0.34.6/src && /usr/bin/gcc  
-I/builddir/build/BUILD/mz-0.34.6/. -I/builddir/build/BUILD/mz-0.34.6/..
-I/builddir/build/BUILD/mz-0.34.6   -o CMakeFiles/mz.dir/layer1.o   -c
/builddir/build/BUILD/mz-0.34.6/src/layer1.c
---------------------------------------------------------------
    As the result the debuginfo rpm is incomplete.

* %files
  - Usually "INSTALL" file is for people who want to build and install
    a package by themselves and not needed for people using rpm.
  - Please remove unneeded %doc line.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.