[Bug 512724] Review Request: perl-Devel-FindRef - Track down reference problems

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512724


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-07-23 02:17:40 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1489183
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
62d99383fdeba001778fe1614529189632e125fb  Devel-FindRef-1.42.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=1,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.01 cusr  0.00
csys =  0.03 CPU)
+ Package perl-Devel-FindRef-1.42-1.fc12.i686 =>
Provides: FindRef.so perl(Devel::FindRef) = 1.42
Requires: libc.so.6 libc.so.6(GLIBC_2.1.3) perl(Scalar::Util) perl(XSLoader)
perl(strict) rtld(GNU_HASH)

+ Not a GUI application

Suggestions:
1) Use
 %{perl_vendorarch}/Devel
 %{perl_vendorarch}/auto/Devel
in %files

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.