[Bug 492810] Review Request: RabbIT - proxy for a faster web
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jul 23 19:10:11 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=492810
Simon Wesp <cassmodiah at fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |cassmodiah at fedoraproject.or
| |g
Flag| |fedora-review?
--- Comment #13 from Simon Wesp <cassmodiah at fedoraproject.org> 2009-07-23 15:10:09 EDT ---
=== REVIEW RabbIT ===
template:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines#Things_To_Check_On_Review
* MUST: rpmlint must be run on every package. The output should be posted in
the review.
FAIL:
RabbIT.noarch: W: name-repeated-in-summary RabbIT
The name of the package is repeated in its summary. This is often redundant
information and looks silly in various programs' output. Make the summary
brief and to the point without including redundant information in it.
RabbIT.noarch: W: non-standard-uid /usr/share/doc/RabbIT-3.18 rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /etc/RabbIT/access rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid
/usr/share/RabbIT/htdocs/public/smallRabbIT3.png rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/RabbIT/htdocs/public rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /etc/RabbIT/cache_only.conf rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/doc/RabbIT-3.18/Help.txt rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /etc/RabbIT/RabbIT.conf rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/doc/RabbIT-3.18/README rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/RabbIT/htdocs rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /etc/RabbIT/nocache.conf rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /etc/RabbIT/users rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/doc/RabbIT-3.18/LICENSE rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /etc/RabbIT/allowed rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /var/log/RabbIT rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/RabbIT/htdocs/index.html rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/RabbIT/htdocs/javadoc rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/RabbIT/htdocs/menu.html rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid
/usr/share/RabbIT/htdocs/technical_documentation rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/RabbIT/htdocs/LICENSE.txt rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/doc/RabbIT-3.18/TODO rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/bin/RabbIT rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid
/usr/share/RabbIT/htdocs/technical_documentation/thread_handling_overview.txt
rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/java/RabbIT-3.18.jar rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/doc/RabbIT-3.18/ChangeLog rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/RabbIT/htdocs/README.txt rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: non-standard-uid /usr/share/RabbIT/htdocs/public/NoAd.gif
rabbit
A file in this package is owned by a non standard user. Standard users are:
root, bin, daemon, adm, lp, sync, shutdown, halt, mail, news, uucp, operator,
games, gopher, ftp, nobody.
RabbIT.noarch: W: log-files-without-logrotate /var/log/RabbIT
This package contains files in /var/log/ without adding logrotate
configuration for them.
RabbIT.noarch: W: dangerous-command-in-%postun userdel
RabbIT.noarch: W: missing-lsb-keyword Default-Stop in /etc/rc.d/init.d/RabbIT
The package contains an init script that does not contain one of the LSB init
script comment block convention keywords that are recommendable for all init
scripts. If there is nothing to add to a keyword's value, include the keyword
in the script with an empty value. Note that as of version 3.2, the LSB
specification does not mandate presence of any keywords.
RabbIT.noarch: E: incoherent-subsys /etc/rc.d/init.d/RabbIT RabbIT}
The filename of your lock file in /var/lock/subsys/ is incoherent with your
actual init script name. For example, if your script name is httpd, you have
to use 'httpd' as the filename in your subsys directory. It is also possible
that rpmlint gets this wrong, especially if the init script contains
nontrivial shell variables and/or assignments. These cases usually manifest
themselves when rpmlint reports that the subsys name starts a with '$'; in
these cases a warning instead of an error is reported and you should check the
script manually.
RabbIT.noarch: W: no-reload-entry /etc/rc.d/init.d/RabbIT
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.
RabbIT.noarch: W: incoherent-init-script-name RabbIT
The init script name should be the same as the package name in lower case, or
one with 'd' appended if it invokes a process by that name.
RabbIT.noarch: W: class-path-in-manifest /usr/share/java/RabbIT-3.18.jar
The META-INF/MANIFEST.MF file in the jar contains a hardcoded Class-Path.
These entries do not work with older Java versions and even if they do work,
they are inflexible and usually cause nasty surprises.
RabbIT.src: W: name-repeated-in-summary RabbIT
The name of the package is repeated in its summary. This is often redundant
information and looks silly in various programs' output. Make the summary
brief and to the point without including redundant information in it.
2 packages and 0 specfiles checked; 1 errors, 34 warnings.
* MUST: The package must be named according to the Package Naming Guidelines.
O.K.
* MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
O.K.
* MUST: The package must meet the Packaging Guidelines.
FAIL
- BUILDROOT-Tag -> O.K.
- No internal libs -> O.K.
- TIMESTAMPS -> O.K.
- File Permissions -> FAIL
* MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
O.K.
* MUST: The License field in the package spec file must match the actual
license.
O.K.
* MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
O.K.
* MUST: The spec file must be written in American English.
O.K.
* MUST: The spec file for the package MUST be legible.
O.K.
* MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
O.K.
my DL:
.:[ cassmodiah @ schafwiese : /home/cassmodiah/Desktop ]:.
$ md5sum RabbIT3-src.tar.gz
49c4c7c568e4b47960601297d26c5efb RabbIT3-src.tar.gz
extract from package:
.:[ cassmodiah @ schafwiese : /home/cassmodiah/rpmbuild/SOURCES ]:.
$ md5sum RabbIT3-src.tar.gz
49c4c7c568e4b47960601297d26c5efb RabbIT3-src.tar.gz
* MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
O.K.
BuildArchitectures: noarch
* MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
N/A
* MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
O.K.
* MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
N/A
* MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
N/A
* MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
N/A
* MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
O.K.
* MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
O.K.
* MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
FAIL
* MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
O.K.
* MUST: Each package must consistently use macros.
O.K.
* MUST: The package must contain code, or permissable content.
O.K.
* MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
N/A
* MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present.
O.K.
* MUST: Header files must be in a -devel package.
N/A
* MUST: Static libraries must be in a -static package.
N/A
* MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
N/A
* MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package.
N/A
* MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
N/A
* MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
N/A
* MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
N/A
* MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.
FAIL
* MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
O.K.
* MUST: All filenames in rpm packages must be valid UTF-8.
O.K.
SHOULD Items:
Items marked as SHOULD are things that the package (or reviewer) SHOULD do, but
is not required to do.
* SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
N/A
* SHOULD: The description and summary sections in the package spec file should
contain translations for supported Non-English languages, if available.
N/A, but O.K.
* SHOULD: The reviewer should test that the package builds in mock.
O.K.
* SHOULD: The package should compile and build into binary rpms on all
supported architectures.
O.K.
* SHOULD: The reviewer should test that the package functions as described. A
package should not segfault instead of running, for example.
N/A
* SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague,
and left up to the reviewers judgement to determine sanity.
O.K.
* SHOULD: Usually, subpackages other than devel should require the base package
using a fully versioned dependency.
N/A
* SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and
this is usually for development purposes, so should be placed in a -devel pkg.
A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb.
O.K.
* SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
O.K.
-----
TODO:
- update to RabbIT 4
- try to contact upstream - he/she/it should use name and version as source,
not only mainversion.
- don't own with the rabbit-user the whole package
- remove my name from your changelog
- don't use packagename in summary
- own %{_datadir}/%{name}/ instead of %{_datadir}/%{name}/htdocs
- you can use a macro in source0; %{name}3 instead of RabbIT3
- make your package RPMLINT-conform:
~ remove class path in manifest
~ you can't avoid all user-messages from rpmlint (/var/run/ and so is okay
for rabbit)
~ userdel is okay
~ add a logrotate for log-files
~ make your init.d-script conform
~ check your user and your service name - you have rabbit and RabbIT -> just
use rabbit for all
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list