[Bug 513486] Review Request: python-meh - A python library for handling exceptions

bugzilla at redhat.com bugzilla at redhat.com
Thu Jul 23 20:46:40 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513486





--- Comment #1 from Jeremy Katz <katzj at redhat.com>  2009-07-23 16:46:39 EDT ---
NEEDSWORK:
* rpmlint output isn't clean
   python-meh.src: E: no-buildroot-tag
   2 packages and 0 specfiles checked; 1 errors, 0 warnings.
* Fails to build in mock (missing buildrequires on intltool at least)
* Should have directions for creating the tarball above the source line (git
clone, etc) rather than just saying source is only in the tarball.  See the
guidelines for building out of an SCM snapshot
* make should be run in %build, not %prep
* Should include a license file as COPYING and then include that in %doc


Otherwise, looks okay but those have to be fixed for an import

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list