[Bug 513733] Review Request: entertainer - A simple media center

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513733





--- Comment #4 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-25 15:10:34 EDT ---
The package builds fine in rawhide, koji build at
http://koji.fedoraproject.org/koji/taskinfo?taskID=1514269

I wasn't able to build it locally in mock, though, due to some errors like
 rpmlib(PayloadIsXz) <= 5.2-1 is needed by libstdc++-devel-4.4.1-2.x86_64
 rpmlib(PayloadIsXz) <= 5.2-1 is needed by cpp-4.4.1-2.x86_64
Rawhide is currently in a bit of a state of mess as F12 mass rebuilds are
taking place.

**

I think this package should be good to go now. You still have to do the second
unofficial review, don't you?


A couple of final, mostly stylistic comments:


- I'd like to see more comments in the spec file. Even though the lines may
seem clear to you now, they might not in the future (or for other people).

I suggest dividing the Requires in two parts, e.g.
 # Needed for dir ownership
 Requires: hicolor-icon-theme
 # These packages are needed for operation
 Requires: pyclutter-cairo
and so on. N.B. Remember to especially note the exceptions in the list, such as
pyclutter-storm-sqlite instead of plain pyclutter-storm.

- Instead of
 #We have .png and .svg files:
 %{_datadir}/icons/hicolor/*/apps/entertainer.???
you could just write
 %{_datadir}/icons/hicolor/*/apps/entertainer.png
 %{_datadir}/icons/hicolor/*/apps/entertainer.svg
or even
 %{_datadir}/icons/hicolor/*/apps/entertainer.png
 %{_datadir}/icons/hicolor/scalable/apps/entertainer.svg

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.