[Bug 512263] Review Request: audtty - A ncurses based terminal client for the Audacious

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512263


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #4 from Christoph Wickert <fedora at christoph-wickert.de>  2009-07-25 16:26:40 EDT ---
(In reply to comment #3)

> All points should be fixed.  Thanks.

The way you install the manpage doesn't work, because the file is not gzipped:

gzip: ./usr/share/man/man1/audtty.1.gz: not in gzip format
ls: cannot access ./usr/share/man/man1/audtty.1: No such file or directory
find: missing argument to `-inum'
gzip: ./usr/share/man/man1/audtty.1: No such file or directory

But this in %build:

gzip -cn9 audtty.1 > audtty.1.gz && \
touch -r audtty.1 audtty.1.gz

And then install the gzipped one.

> The usage of autogen.sh ended with debuginfo-without-sources.  That's the
> reason why I use the commands out of autogen.sh in the spec file.

Ok, but then the changelog is not correct, because it says you switched to
autogen.sh. Please fix this and the manpage before build.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.