[Bug 513541] Review Request: cpulimit - CPU Usage Limiter for Linux

bugzilla at redhat.com bugzilla at redhat.com
Sat Jul 25 21:31:57 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513541





--- Comment #14 from Fabian Affolter <fabian at bernewireless.net>  2009-07-25 17:31:56 EDT ---
Sorry, my fault... INSTDIR should be DESTDIR.  

make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

https://fedoraproject.org/wiki/How_to_create_an_RPM_package#.25install_section

As I already said as long the doc files and the man page aren't upstream this
is only cosmetically.

(In reply to comment #13)
> So I added "install -p" to ./configure. Will this work as expected to preserve
> timestamps?

No, I was misleading you.  Can you please fix this? Then I will make a full
review.

BTW, I'm not a sponsor.  You can get some hints on that process at the
following page
https://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored . The long
story short: Make some informal reviews of other packages and make some more
packages to show that you understand the guidelines and are familiar with them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list