[Bug 488174] Review Request: nimbus-theme-gnome - The Nimbus theme originally from Sun

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488174


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #17 from Christoph Wickert <fedora at christoph-wickert.de>  2009-07-25 21:59:55 EDT ---
Sorry it took so long, but there was a problem with my first patch and I did
not find the time to look into this. The iconrc was installed in the wrong
location and some icons caused trouble on some sizes.

Two more directories need to be dropped from the files listing:

@@ -116,13 +116,11 @@
 %defattr(-,root,root,-)
 %doc AUTHORS ChangeLog COPYING
 %{_datadir}/icons/nimbus/
-%dir %{_datadir}/themes/nimbus/
 %ghost %{_datadir}/icons/nimbus/icon-theme.cache

 %files -n nimbus-theme-gnome
 %defattr(-,root,root,-)
 %{_datadir}/themes/nimbus/index.theme
-%dir %{_datadir}/themes/nimbus/gtk-2.0/

 %changelog
 * Sat May 16 2009 matej <mcepl at redhat.com> 0.0.17-4

Then the only remaining warning is:
$ rpmlint ~/fedora/rpmbuild/RPMS/noarch/nimbus-*
nimbus-theme-gnome.noarch: W: no-documentation
OK, already shipped with the other packages.

Did you get any feedback on the license? If not release it strict LGPLv2.

Update the package and consider it APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.