[Bug 511966] Review Request: zbar - bar code reader
bugzilla at redhat.com
bugzilla at redhat.com
Sun Jul 26 16:57:44 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=511966
--- Comment #14 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2009-07-26 12:57:43 EDT ---
For -3:
* SourceURL
- Missed in the previous comment, however for sourceforge hosted
source, please follow:
https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
* Requires / BuildRequires
- "BuildRequires: libX11-devel" is redundant because
gtk2-devel requires this (and this is also in BuildRequires).
https://fedoraproject.org/wiki/Packaging/Guidelines#Requires
- Now "Requires: ImageMagick-c++" on the main package is redundant
(and should be removed) as the dependencies for libraries automatically
detected by rpmbuild should pull in this dependency:
- And again "Requires: gtk2" on -gtk subpackage, and "Requires: qt >= 4"
on -qt subpackage are redundant (and should be removed).
- "Requires: %{name} = %{version}-%{release}" on -pygtk subpackage
is redundant because -pygtk subpackage requires -gtk subpackage and
-gtk subpackage requires main package.
* Provides
- "Provides: libzbar-static" on -devel subpackage must be removed
because no static archives are now included (and same on other
devel related subpackages)
* Directory ownership issue
- The %files entry
---------------------------------------------------------
%files
%{_includedir}/zbar
---------------------------------------------------------
contains the directory %_includedir/zbar itself and all
files/directories/etc under this directory (please check
what $ rpm -ql zbar-devel returns), while
---------------------------------------------------------
%files
%dir %{_includedir}/zbar
---------------------------------------------------------
contains the directory %_includedir/zbar only.
* Macros in %changelog
- In changelog, please use %% instead of % to keep macros from
being expanded ($ rpm -q --changelog zbar
shows what is actually occuring)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list