[Bug 513307] Review Request: Netdisco - A web-based network management tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513307





--- Comment #3 from Walter Gould <walt at gouldfamily.org>  2009-07-26 17:30:24 EDT ---
Ok, fixed the blocks.

* You should change /usr/share/ to %_datadir in the %files section -- DONE
* Most of the explicit %attr aren't required in %files -- DONE 
* Patches are suppose to have comments: Although it might be easier just to
change those patches to seds. -- DONE; On this one, I fixed the files w/o
applying patches. 
* I know nothing about the vendor mips packaged in netdisco-mips, I'm assuming
you know if they're allowed to be packaged in Fedora or not. -- DONE; These are
MIB (Management Information Base) files that network vendors offer to the
public that allow their devices (switches/routers) to be monitored.  Since they
are offered freely to the public, there shouldn't be a problem in including
them in this package.   

Below are the new spec file and src rpm.

http://auburn.edu/~gouldwp/netdisco/rpms/netdisco-0.95-2.fc11.src.rpm
http://auburn.edu/~gouldwp/netdisco/rpms/netdisco.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.