[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 27 09:51:22 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497622





--- Comment #33 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-27 05:51:19 EDT ---
(In reply to comment #32)
> > Package does not build:
> > RPM build errors:
> >     File not found:
> > /builddir/build/BUILDROOT/apbs-1.1.0-5.fc11.x86_64/usr/bin/ApbsClient.pyc
> >     File not found:
> > /builddir/build/BUILDROOT/apbs-1.1.0-5.fc11.x86_64/usr/bin/ApbsClient.pyo
> > 
> > This is due to RPM in Fedora 11 not byte compiling files in %{_bindir}. Instead
> > of %exclude you could just delete the files after %install with rm -f which
> > doesn't complain about possible non-existing files.  
> 
> I just removed the %exclude statement and built using F11 (since I won't be
> packaging this for F10 anyway).
> 
> Spec URL: http://www.stanford.edu/~fenn/packs/apbs.spec
> SRPM URL: http://www.stanford.edu/~fenn/packs/apbs-1.1.0-6.fc11.src.rpm  

.. but won't you be building for EPEL, if you need this for pymol?

**

We usually don't add license files ourselves.

**

You're using ATLAS for ARPACK? You might want to use it for blas, too:
 --with-blas="-L%{_libdir}/atlas -lf77blas -latlas"
should do it.

**

For the tools installation I suggest using a loop:

for bin in tools/manip/{psize.py,coulomb,born}
tools/mesh/{mgmesh,dxmath,mergedx2,mergedx,value,uhbd_asc2bin,smooth,dx2mol,dx2uhbd,similarity,multivalue,benchmark,analysis}
arpack/driver; do
 install -p -m 755 $bin %{buildroot}%{_bindir}/apbs-`basename $bin`
done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list