[Bug 513896] Review Request: pcp - performance monitoring and collection service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513896





--- Comment #2 from Eric Sandeen <esandeen at redhat.com>  2009-07-27 15:08:41 EDT ---
Mark, a few random questions & comments, more may follow.  :)

What is the reason for the Provides: on the libraries?  Generally RPM sorts out
library provides on its own.  If there's something special here it could use a
comment.

What's the reason for all the %attr specifications in the file list?  Does
"make install" not put the proper permissions on them?  Assuming "rpmdiff"
shows permissions differences, there would appear to be no difference and I'd
just lose every explicit %attr set.

also:

%pre
exit 0

the above does nothing and should be removed.

We probably should just not package the static libs unless there's a real
reason for it - is there?  If not, could just rm -f them in %install.

./configure can/should be replaced with %configure, although this seems to
break the build.  :(  I'd have to look and see what the difference is.

Lots of explicit paths can (and I think should?) be referred to w/ macros:

/usr/lib* -> %{_libdir}
/usr/share/man/man3 -> %{_mandir}/man3 (etc)
/usr/bin -> %{_bindir}
/usr/include -> %{_includedir}

In a lot of cases, it may be a lot simpler to use wildcards rather than listing
each file & subdir individually.  For example:

%dir /foo/bar/baz
/foo/bar/baz/*

But if 2 subpackages share files in a subdir they'd need to be explicitly
listed I guess, and only one should own the dir of course.  I guess it's your
preference but wow, that is a long %files list ;)

When I build I get some odd messages:

cpio: pcp-3.0.0/src/dbpmda/src/<stdout>: Cannot stat: No such file or directory
cpio: pcp-3.0.0/src/dbpmda/src/gram.tab.c: Cannot stat: No such file or
directory
cpio: pcp-3.0.0/src/pmie/src/grammar.tab.c: Cannot stat: No such file or
directory
cpio: pcp-3.0.0/src/pmlc/<stdout>: Cannot stat: No such file or directory
cpio: pcp-3.0.0/src/pmlc/gram.tab.c: Cannot stat: No such file or directory
cpio: pcp-3.0.0/src/pmlogextract/<stdout>: Cannot stat: No such file or
directory
cpio: pcp-3.0.0/src/pmlogextract/gram.tab.c: Cannot stat: No such file or
directory
cpio: pcp-3.0.0/src/pmlogger/<stdout>: Cannot stat: No such file or directory
cpio: pcp-3.0.0/src/pmlogger/gram.tab.c: Cannot stat: No such file or directory

I think these are generated files, and the debuginfo collection step isn't able
to find them.  This may mean that the debuginfo rpms are incomplete?

You might be able to simplify the README installation etc (DOCFILES) by
dropping their install from the makefiles, and just doing:

%files
%doc README COPYING FOO BAR

I'm not sure if hand-recreating what %doc does has any pitfalls or not.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.