[Bug 503847] Review Request: paperbox - A GTK tracker based document browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503847





--- Comment #11 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-27 17:05:34 EDT ---
(In reply to comment #10)
> Hello no movement as per your comment #6 Jussi. Have no updated gtkmm-utils as
> you no doubt know.  

Right.

**

There's no need to run
 --remove-key Encoding                                   \

you can
 --remove-category=GNOME
as it doesn't serve any purpose in Fedora

and the Applications category is obsolete, so drop
 --add-category Applications                             \
(keep the --remove-category=Application)

**

You're running desktop-file-install, so you should give as source file
 data/paperbox.desktop
instead of
 $RPM_BUILD_ROOT%{_datadir}/applications/paperbox.desktop

**

The package builds for Fedora 10, but not for Fedora 11. This will have to be
fixed. Too bad Mamoru has already removed the necessary patch.

**

You are missing the %posttrans phase of the icon cache update.

**

The license is GPLv2+ not GPLv2 (see source code).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.