[Bug 513636] Review Request: php-layers-menu - Hierarchical PHP based DHTML menu system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513636


David Nalley <david at gnsa.us> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #6 from David Nalley <david at gnsa.us>  2009-07-27 22:41:07 EDT ---
I think requires should be php-pear-HTML_Template_PHPLIB. I assume you can fix
this before it hits CVS. Of course pushing to stable should probably wait on
the dependency. 

So I see the readme.fedora and the find/sed statement for fixing the demo
stuff. I wonder if it would be easier to just symlink the 'system' PHPLIB.php
into it's current location. No requirement there, just food for thought.
(despite the fact that bundling libraries is forbidden by packaging guidelines,
there is no guidance that I am aware of on how to handle the library
unbundling.) Queries to -devel have provided a mixed response of essentially
'patching' the source, and symlinking, so I don't know that there is a wrong
answer here. 

APPROVED


BTW, thanks for your work on this, it helps takes care of a bundling issue in
one of my packages I wasn't aware of until I started the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.