[Bug 513869] Review Request: perl-Beanstalk-Client - Client class to talk to a beanstalkd server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513869





--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-07-28 06:17:19 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1534328
- rpmlint output messages for SRPM and for RPM.
perl-Beanstalk-Client.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1,
tab: line 15)
==> Can be fixed using 
sed -i -e 's|\t| |g' perl-Beanstalk-Client.spec
+ source files match upstream url
8a95bef54fe681f25752849e6fce6f0e3e742e43  Beanstalk-Client-1.05.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=2, Tests=68,  1 wallclock secs ( 0.03 usr  0.00 sys +  0.10 cusr  0.03
csys =  0.16 CPU)
+ Package perl-Beanstalk-Client-1.05-1.fc12.noarch =>
Provides: perl(Beanstalk::Client) = 1.05 perl(Beanstalk::Job) = 1.02
perl(Beanstalk::Pool) = 0.00 perl(Beanstalk::Stats) = 1.02
Requires: perl(Beanstalk::Job) perl(Beanstalk::Stats) perl(Carp) perl(Error)
perl(IO::Socket::INET) perl(Socket) perl(YAML::Syck) perl(base) perl(strict)
perl(warnings)

+ Not a GUI application

Should:
1) Working Source URL is
http://search.cpan.org/CPAN/authors/id/G/GB/GBARR/Beanstalk-Client-1.05.tar.gz
update in SPEC.

2) you don't need following Requires in spec. Yum will auto install it.
Requires:       perl(Class::Accessor::Fast)
Requires:       perl(Error)
Requires:       perl(YAML::Syck)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.