[Bug 508518] Review Request: Meiga - Easy tool for file sharing and content publishing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508518


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #2 from Fabian Affolter <fabian at bernewireless.net>  2009-07-28 06:42:24 EDT ---
Just some comments after a quick look at your spec file

- License should be GPLv2+.  The source headers says 'or (at your option) any
later version.'
- Requires: hicolor-icon-theme is missing
- ChangeLog, MAINTAINERS and NEWS are missing in %doc
- Wouldn't it be easier for the future just to use %{_datadir}/%{name}/

instead of 

%dir %{_datadir}/%{name}
%dir %{_datadir}/%{name}/ui
%{_datadir}/%{name}/ui/gui.ui
%{_datadir}/%{name}/ui/%{name}-16x16.png   

?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.