[Bug 513754] Review Request: moblin-session - Moblin User Experience Startup Scripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513754





--- Comment #5 from Gareth John <gareth.l.john at googlemail.com>  2009-07-28 10:20:29 EDT ---
MUST: rpmlint must be run on every package. The output should be posted in the
review....OK
MUST: The package must be named according to the Package Naming
Guidelines....OK
MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption....OK
MUST: The package must meet the Packaging Guidelines....OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines....OK
MUST: The License field in the package spec file must match the actual
license....OK
MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc....OK
MUST: The spec file must be written in American English....OK
MUST: The spec file for the package MUST be legible....OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this....OK
MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture....OK
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line....N/A
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional....OK
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden....N/A
MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun....N/A
MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker....N/A
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory....OK
MUST: A Fedora package must not list a file more than once in the spec file's
%files listings....OK
MUST: Permissions on files must be set properly. Executables should be set with
executable permissions....OK
MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT)....OK
MUST: Each package must consistently use macros....OK
MUST: The package must contain code, or permissable content....OK
MUST: Large documentation files must go in a -doc subpackage....OK
MUST: If a package includes something as %doc, it must not affect the runtime
of the application....N/A
MUST: Header files must be in a -devel package....N/A
MUST: Static libraries must be in a -static package....N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability)....N/A
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package....N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}....N/A
MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built....N/A
MUST: Packages containing GUI applications must include a %{name}.desktop file,
and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your
explanation....N/A
MUST: Packages must not own files or directories already owned by other
packages....OK
MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT)....OK
MUST: All filenames in rpm packages must be valid UTF-8....OK

As far as I see all guidelines are met hope I havent missed anything Jussi.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.