[Bug 512725] Review Request: perl-Devel-Refcount - Obtain the REFCNT value of a referent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512725


Emmanuel Seyman <emmanuel.seyman at club-internet.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Emmanuel Seyman <emmanuel.seyman at club-internet.fr>  2009-07-29 08:19:22 EDT ---

Sorry, it took so long, Nicolas. Getting koji to complete a scratch build
was impossible for a few days.

Review:
+ package builds in mock (f12).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1562366
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
97398b8091432ebe16528d13d1169233  Devel-Refcount-0.06.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=28,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.14 cusr  0.02
csys =  0.20 CPU)
Result: PASS
+ Package perl-Devel-Refcount-0.06-1.fc12.i686 =>
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <=
3.0.3-1
libc.so.6 libc.so.6(GLIBC_2.1.3) perl(base) perl(strict) perl(warnings)
rtld(GNU_HASH)
Provides: Refcount.so perl(Devel::Refcount) = 0.06

Nitpick: I find

%{perl_vendorarch}/auto/Devel*
%{perl_vendorarch}/Devel*

to be more readable than

%{perl_vendorarch}/auto/*
%{perl_vendorarch}/Devel*

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.