[Bug 513541] Review Request: cpulimit - CPU Usage Limiter for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513541





--- Comment #19 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-29 08:26:24 EDT ---
(In reply to comment #18)
> (In reply to comment #16)
> > Don't bother with autotools. There's nothing wrong with a package that builds
> > without them, especially when the build process is this simple.
> 
> I agree, but my recommendation is a small patch to makefile without auto-tools.
> and sending this small patch to upstream of cpulimit.  

Yes, that is fine too. Then the makefile should look like


 BINDIR=/usr/local/bin
 MANDIR=/usr/local/man
 INSTALL="install"
 CFLAGS="-Wall -O2"

 all::   cpulimit

 cpulimit:       cpulimit.c
         gcc ${CFLAGS} -o cpulimit cpulimit.c -lrt

 clean:
         rm -f cpulimit

 install:
         ${INSTALL} -D -m 755 cpulimit ${DESTDIR}${BINDIR}
         ${INSTALL} -D -m 644 cpulimit.1 ${DESTDIR}${MANDIR}/man1/cpulimit.1


By default this will compile with "-Wall -O2" and install to /usr/local/bin. In
the spec file one would use

 %build
 make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"
to override the CFLAGS variable in Makefile and

 %install
 make DESTDIR=$RPM_BUILD_ROOT BINDIR=%{_bindir} MANDIR=%{_mandir}
INSTALL="install -p" install
to override the other variables. One can also do without DESTDIR support, then
one just prepends $RPM_BUILD_ROOT to MANDIR and BINDIR.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.