[Bug 513541] Review Request: cpulimit - CPU Usage Limiter for Linux

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513541





--- Comment #23 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-07-29 20:26:43 EDT ---
(In reply to comment #22)
> Ok, so as suggested, I got rid of autotools and made a patch for the Makefile.
> 
> The man page was not included by upstream, I got that from the debian package.
> If I do not include the man page, rpmlint warns about no documentation.
> So I decided to include the man page as Source1. (and sent it upstream on
> sf.net)
> 
> If that's not a good idea, I will remove the man page and let the warning be.

OK. Debian considers not having a man file a packaging error, so they have the
tendency of generating them if they do not already exist.

In Fedora we do not do so; we try to stay as close to upstream as possible and
thus if there is no documentation in the tarball we don't ship any, either. I
wouldn't ship the man page (generally there's no guarantee that it isn't
obsolete), but you should send it upstream to see if they could include it in
the next release. Also ask them to add the relevant license file, i.e.
http://www.gnu.org/licenses/gpl-2.0.txt

Some times you don't have to care about rpmlint warnings. The no-doc warning is
the most common of these cases; you just have to check if there is something
that should be put there.

> Thanks everyone for their comments.
> 
> Jussi, thanks for the sponsorship offer.
> I'll make a few more packages and review some packages soon.
> I intend to make/maintain packages on a regular basis.

Good, since packaging shouldn't be a one-off activity :)

Paste the numbers of the BZ entries here so I can check them out.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.