[Bug 512170] Review Request: pidgin-sipe - Pidgin plugin for connecting to MS Communications Server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512170





--- Comment #13 from Stefan Becker <stefan.becker at nokia.com>  2009-07-30 12:56:38 EDT ---
(In reply to comment #11)
> (In reply to comment #9)
> > There may be a real bug there too -- shouldn't we multiply both strlen(user)
> > and strlen(hostname) by 2 when we calculate msglen, because they'll be
> > converted to UCS-2 (or UTF-16).  
> 
> I'm not sure, LC/OC servers accept the authentication the code generates :-)
> But I'll check it. As far as I know the code was copied from another source
> originally.  

The code is IMHO correct, you just missed the () after the multiplication:

 2*(strlen(domain) + strlen(user) + strlen(hostname) +
NTLMSSP_NT_OR_LM_KEY_LEN)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.