[Bug 514065] Review Request: trac-tracnav-plugin - Navigation Bar for Trac

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514065





--- Comment #2 from Thomas Moschny <thomas.moschny at gmx.de>  2009-07-31 16:25:49 EDT ---
(In reply to comment #1)
> Issues I found:
> According to [1] %global is preferred over %define, so line 3 should be changed
> to %global.

Fixed.

> Try to bail out the 80 chars in the description.

If you insist, but normally I have emacs' fill-column set to 70 (the default,
as far as I know).

> I don't like the %{python_sitelib}/* construct in the %files section

Unless there's a guideline that forces me to do so, I'd prefer not to list
individual files or directories here, because removing redundancy makes
maintaining the package much easier.

Spec URL:
http://thm.fedorapeople.org/trac-tracnav-plugin/trac-tracnav-plugin.spec
SRPM URL:
http://thm.fedorapeople.org/trac-tracnav-plugin/trac-tracnav-plugin-4.1-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.