[Bug 503202] Review Request: blueproximity - A tool that locks/unlocks your screen when your bluetooth devices gets away/near from your computer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503202


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review?




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-06-01 01:56:25 EDT ---
1) use patch names prefixed with package name
Patch0:         blueproximity-fedorization.diff
Patch1:         blueproximity-fix-bash-script.diff
also, change %prep as
%patch0 -p0 -b .fedorization
%patch1 -p0 -b .fix-bash-script

2) no need to use vendor in desktop-file-install. See
http://fedoraproject.org/wiki/PackagingGuidelines#desktop-file-install_usage
Remove fedora word from fedora-blueproximity.desktop file name.

3) files section should look like
%files -f %{name}.lang
%defattr(-,root,root,-)
%doc ChangeLog COPYING README doc/
%{_datadir}/%{name}
%{_bindir}/%{name}
%{_datadir}/applications/fedora-%{name}.desktop
%{_datadir}/pixmaps/%{name}_base.svg

4) fix following warning
fedora-blueproximity.desktop: key "Categories" is a list and does not have a
semicolon as trailing character

5) preserve timestamps by using install command as "install -p"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.