[Bug 503031] Review Request: easystroke - Gesture-recognition application for X11
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jun 1 09:15:19 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=503031
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review?
--- Comment #3 from Parag AN(पराग) <panemade at gmail.com> 2009-06-01 05:15:18 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1386455
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
4b196b07524f55422c64113aee1a5bcbbf249ee9 easystroke-0.4.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ gtk-update-icon-cache scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop file installed correctly.
+ GUI application
Suggestions:
1) I don't see mimetype written in desktop file so according to
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database,
drop update-desktop-database from SPEC.
2) I think you should own only svg file and add
Requires: hicolor-icon-theme
and change in %files as
%{_datadir}/icons/hicolor/scalable/apps/easystroke.svg
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list