[Bug 226508] Merge Review: tvtime

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226508





--- Comment #9 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-06-01 08:40:10 EDT ---
rpmlint output is clean.


MUST: The spec file for the package is legible and macros are used
consistently. NEEDSWORK
- You are using %{buildroot} and $RPM_OPT_FLAGS, please change the latter to
%{optflags}.

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- Some files are  MIT licensed (e.g. src/xfullscreen.{c,h}), but MIT license is
compatible with GPL/LGPL.
- Also LGPL is compatible with GPL, so license tag could in principle be just
GPLv2+.
- Current GPLv2+ and LGPLv2+ is most informative, so it's best to keep it as it
is.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK

MUST: Optflags are used and time stamps preserved. NEEDSWORK
- Time stamps are not conserved in install, add INSTALL="install -p" as
argument to make install.

MUST: Packages containing shared library files must call ldconfig. N/A

MUST: A package must own all directories that it creates or require the package
that owns the directory. NEEDSWORK
- Package must Requires: hicolor-icon-theme for dir ownership. (no
Requires(post): and Requires(postun): hicolor-icon-theme, should be just
Requires: hicolor-icon-theme).

MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK

MUST: Permissions on files must be set properly. NEEDSWORK
- I don't think directories can be listed as config. I'd change
 %config(noreplace) %{_sysconfdir}/tvtime/
to
 %dir %{_sysconfdir}/tvtime/
 %config(noreplace) %{_sysconfdir}/tvtime/tvtime.xml

MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSWORK
- Include COPYING.LGPL.

MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.