[Bug 503256] Review Request: gtkmm-utils - C++ utility and widget library based on glibmm and gtkmm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=503256





--- Comment #24 from Gareth John <gareth.l.john at googlemail.com>  2009-06-01 14:06:41 EDT ---
-------------------------------
* Mon Jun 01 2009 Gareth John gareth.l.john at googlemail.com 0.4.0-6
- Added doc pack/description/files
- Enabled doc build in configure
- Added doxygen buildreq for -doc
- Added glibmm24-devel to BR
- Added examples pkg
- Added move commands under install
- Added mkdir command under install
--------------------------------
Rpmlint says:

$ rpmlint -i RPMS/i386/gtkmm-utils-example-0.4.0-6.fc10.i386.rpm 
gtkmm-utils-example.i386: W: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

gtkmm-utils-example.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

1 packages and 0 specfiles checked; 0 errors, 2 warnings.

$ rpmlint -i RPMS/i386/gtkmm-utils-doc-0.4.0-6.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint RPMS/i386/gtkmm-utils-devel-0.4.0-6.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint RPMS/i386/gtkmm-utils-0.4.0-6.fc10.i386.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint SRPMS/gtkmm-utils-0.4.0-6.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
---------------------------------
Files:
http://garethsrpms.googlecode.com/files/gtkmm-utils.spec
http://garethsrpms.googlecode.com/files/gtkmm-utils-0.4.0-6.fc10.src.rpm
---------------------------------
I followed Michaels comment on the BRs and edited them. Also added the doc
subpackage which includes the docs for developers, this also made me add
doxygen as a BR. Following on from previous comments i assume that the one
warning in examples is justified as it would just be replicated doc from main
package. Also the dir i put it in following comments threw up a warning again i
assume this is ok?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.