[Bug 492715] Review Request: KRadio4 - V4L/V4L2-Radio Application for KDE4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492715





--- Comment #32 from Paulo Roma Cavalcanti <promac at gmail.com>  2009-06-02 06:06:35 EDT ---

> 
> 4) %cmake can be: %cmake_kde4 

I was already using %cmake_kde4. Where did you see only %cmake??

> 
> 5) after removing %define lines you must change:
> 
> cp -R %{_builddir}/%{name}-%{rel}/html/* \
> to 
> cp -R %{_builddir}/%{name}-%{version}/html/* \
> 
> 6) .desktop file do not contain mimetype key, so we can now remove these lines
> from %post and %postun:
> 
> update-desktop-database &> /dev/null || :
> 
> (This is my mistake ;) )
> 
> 7) Maybe the most important thing!

> 
> Are you sure that we can make package for internet radio as a nonfree package,
> and just install them to Kradio works properly, without need to rebuild
> (compile) Kradio4 with needed BR: -devel packages???
> 
> Because, if we must build Kradio4 package with nonfree -devel dependencies,
> than Kradio4 must fo to RPM Fusion for full functionality.
> 
> I ask because I saw that builder, at configure time ask for these nonfree devel
> dependencies...

It checks for them, but the build goes just fine this way.

> 
> Can you chack this on some way?  

Well, I am using kradio4 exactly this way. I built and installed the Fedora
package, and then installed only the internet radio package. It is working just
fine.

I made all the modifications, but I kept the release as 1, If you do not mind,
because I would like to deploy the Fedora package using 1 for its first
release.

For now I only update the Fedora package. Same URLS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.