[Bug 492397] Review Request: websvn - Online subversion repository browser

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492397


Jan Klepek <jan.klepek at hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #12 from Jan Klepek <jan.klepek at hp.com>  2009-06-03 01:52:06 EDT ---
MUST: rpmlint must be run on every package. The output should be posted in the
review.
- rpmlint /home/makerpm/rpmbuild/SRPMS/websvn-2.2.1-1.fc10.src.rpm
/home/makerpm/rpmbuild/RPMS/noarch/websvn-2.2.1-1.fc10.noarch.rpm
SPECS/websvn.spec 
websvn.noarch: W: non-standard-uid /var/cache/websvn apache
websvn.noarch: W: dangling-relative-symlink /usr/share/websvn/temp
../../../var/tmp
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
- OK, non-standard-uid caused by owning files with apache user

MUST: The package must be named according to the Package Naming Guidelines
- OK

MUST: The spec file name must match the base package %{name}
- OK

MUST: The package must meet the Packaging Guidelines
- OK

MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines
- OK

MUST: The License field in the package spec file must match the actual license.
- OK

MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
- OK

MUST: The spec file must be written in American English.
- OK

MUST: The spec file for the package MUST be legible.
- OK

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
- OK

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
- OK, builded and working on fc10 at x86

MUST: If the package does not successfully compile, build or work on an
architecture, ...
- OK

MUST: All build dependencies must be listed in BuildRequires
- OK
builded ok in KOJI 
http://koji.fedoraproject.org/koji/taskinfo?taskID=1390448

MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. 
- OK

MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun
- OK, no binary package

MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
- OK

MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. 
- OK

MUST: A Fedora package must not list a file more than once in the spec file's
%files listings. 
- OK

MUST: Permissions on files must be set properly.
- OK

MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
- OK

MUST: Each package must consistently use macros.
- OK

MUST: The package must contain code, or permissable content.
- OK

MUST: Large documentation files must go in a -doc subpackage.
- OK

MUST: If a package includes something as %doc, it must not affect the runtime
of the application.
- OK

MUST: Header files must be in a -devel package.
- OK, no header files

MUST: Static libraries must be in a -static package.
- OK, no static libraries

MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for
directory ownership and usability).
- OK

MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel package
- OK, no .so files present

MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
- OK

MUST: Packages must NOT contain any .la libtool archives, these must be removed
in the spec if they are built.
- OK, no .la archives

MUST: Packages containing GUI applications must include a %{name}.desktop file
- OK, not gui application

MUST: Packages must not own files or directories already owned by other
packages.
- OK

MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
- OK
MUST: All filenames in rpm packages must be valid UTF-8.
- OK

Conclusion: APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.