[Bug 501116] Review Request: perl-HTML-CalendarMonthSimple - Perl Module for Generating HTML Calendars

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=501116


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




--- Comment #4 from Jason Tibbitts <tibbs at math.uh.edu>  2009-06-03 16:47:38 EDT ---
OK, I'll just pretend the license is changed as above as I review this.  Just
make the change when you check in.

* source files match upstream.  sha256sum:
   00cdd627996104df5cedee8e78596698917879b726263987d85b38d69d870c62  
   HTML-CalendarMonthSimple-1.25.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(HTML::CalendarMonthSimple) = 1.25
   perl-HTML-CalendarMonthSimple = 1.25-2.fc11
  =
   perl(:MODULE_COMPAT_5.10.0)
   perl(Date::Calc)
   perl(strict)

* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.