[Bug 498845] Review Request: R-msm - Multi-state Markov and hidden Markov models in continuous time

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498845


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2009-06-03 20:05:56 EDT ---
This builds fine and rpmlint is silent except for the two complaints that it
always spews for R packages.

The license is a bit unclear.  DESCRIPTION says "GPL-2", but src/pijt.c (the
only other file that seems to have a license uses the FSF-recommended language
and says GPLv2+.

Can you clarify with upstream whether the code is GPLv2 only or GPLv2+? 
Upstream seems to be active.

Why is the %check section commented out?

* source files match upstream.  sha256sum:
   7dd0e5ce54e67afe7ea40b0ad127b270c7e822a29aaa3e7373fe465bb361026f  
   msm_0.8.2.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
? license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   msm.so()(64bit)
   R-msm = 0.8.2-1.fc11
   R-msm(x86-64) = 0.8.2-1.fc11
  =
   /bin/sh
   R
   libR.so()(64bit)
   libRblas.so()(64bit)
   libRlapack.so()(64bit)
   libgfortran.so.3()(64bit)

? %check is present but commented out.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* scriptlets are OK (R package registration)
* code, not content.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.