[Bug 500928] Review Request: python-sqlparse - Non-validating SQL parser for Python
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jun 4 05:25:53 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500928
Jason Tibbitts <tibbs at math.uh.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |tibbs at math.uh.edu
Flag| |fedora-review?
--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu> 2009-06-04 01:25:52 EDT ---
Builds fine and rpmlint is silent.
There seems to be a test suite included in the tarball. Any reason not to run
it at build time?
* source files match upstream. sha256sum:
6049385a7032628c9a9bc2ac578ce1826e4179b0a8a9f33b535f022fabd8d3ea
sqlparse-0.1.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
python-sqlparse = 0.1.1-1.fc11
=
/usr/bin/python
python(abi) = 2.6
X A test suite is present but not run.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list