[Bug 504283] Review Request: AGReader - Console reader for viewing AmigaGuide files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504283


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review+




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2009-06-05 14:31:37 EDT ---
Indeed, thhis builds fine and rpmlint complains only about the two .guide files
that aren't utf8.

The source files indicate their license only inconsistently.  Where they do,
they mention only "GNU PL" or "GNU license" and often only "free software". 
Since this was in Fedora previously and merely orphaned (not dropped due to
licens, I'm going to make the assume that this was previously cleared to be the
GNU GPL, with no version specified giving GPL+.

I tested thhis manually and it seems to work fine.

* source files match upstream.  sha256sum:
   a8ddd38ac43d9b6f156334a471a66fa93bb83695ef3a99ce62eb8ea3f44e5c08  
   AGReader.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (none needed).
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   AGReader = 1.2-5.fc11
   AGReader(x86-64) = 1.2-5.fc11
  =
   (nothing special)

* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.