[Bug 504077] Review Request: gnusim8085 - Intel 8085 assembly language simulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504077





--- Comment #5 from Chitlesh GOORAH <chitlesh at gmail.com>  2009-06-06 15:24:08 EDT ---
#1: can you give me your FAS username please ?
and apply for the packager status at
https://admin.fedoraproject.org/accounts/group/view/packager

#2 add %{?_smp_mflags} to your make in the %build section

#3: wrong URL

Correct the URL to:
http://gnusim8085.sourceforge.net/

#4: Preserve timestamps
make INSTALL="install -p" DESTDIR=%{buildroot} install

#5: docs
%doc %{_datadir}/doc/gnusim8085/ should rather be :

%doc  ABOUT-NLS AUTHORS ChangeLog COPYING NEWS README TODO
%doc  doc/examples/ doc/asm-guide.txt

Add the following line at the end of the %install
rm -rf %{buildroot}%{_docdir}


#6: Summary should be clear: "A 8085 Simulator"

#7: %description missing fullstop.

#8: License is GPL version 2 only : GPLv2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.