[Bug 504430] Review Request: healpy - A python wrapper of the healpix library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504430


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi
         AssignedTo|nobody at fedoraproject.org    |jussi.lehtola at iki.fi
               Flag|                            |fedora-review?




--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-06-07 03:34:42 EDT ---
- The BRs are incorrect.
 BuildRequires: python
should be
 BuildRequires: python-devel
and
 BuildRequires: gcc-c++
can be safely dropped (it's in the default buildroot).

?? The package uses BOTH python_sitearch AND python_sitelib?? (Are you building
on x86, then these will point to the same place?)

- Why on Earth do you
 mkdir -p %{buildroot}%{_datadir}/%{name}/
 mv %{buildroot}%{python_sitelib}/%{name}/data
%{buildroot}%{_datadir}/%{name}/data
as this will probably break functionality..?

- As the Healpix C++ package is included in the distribution, you need to find
a way to remove it and use healpix-c++-devel instead.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.