[Bug 504077] Review Request: gnusim8085 - Intel 8085 assembly language simulator

bugzilla at redhat.com bugzilla at redhat.com
Sun Jun 7 08:50:09 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504077





--- Comment #8 from Chitlesh GOORAH <chitlesh at gmail.com>  2009-06-07 04:50:08 EDT ---
#1: some typos in the description : stac and microproessor

I think the description should be:

GNUSim8085 is a graphical simulator for Intel 8085
microprocessor assembly language. It has many
features including a keypad which can be used
to write assembly language programs.
It also has stack, memory and port viewers which
can be used for debugging the programs.

#2: directory ownership
in %files
%{_datadir}/pixmaps/gnusim8085/gnusim8085_icon.png

the directory %{_datadir}/pixmaps/gnusim8085/ should be owned by the package.

Hence
%{_datadir}/pixmaps/gnusim8085/gnusim8085_icon.png
should be
%{_datadir}/pixmaps/gnusim8085/

#3:
The package is ready. I have sponsored you.

Update the spec file and SRPM. I'll complete the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list