[Bug 470696] Review Request: rubygem-passenger - Passenger Ruby on Rails deployment system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470696


Hongli Lai <honglilai at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |honglilai at gmail.com




--- Comment #34 from Hongli Lai <honglilai at gmail.com>  2009-06-07 07:12:47 EDT ---
Hi Mamoru. I am one of the authors of Phusion Passenger, and I want to comment
on several issues here:

== Vendoring Boost

We actually use a modified version of Boost, so Phusion Passenger will not
compile against a stock Boost. I understand your concerns with regard to
security, but please rest assured because we fully understand the security
implications of vendoring a library. We will take full responsibilities for any
security problems; that is, we will either backport security fixes or upgrade
our vendored Boost to a newer version.

I hope this addresses any concerns that you might have with regard to vendoring
Boost. If not then I'm eager to hear your thoughts on it.

== native_support.so

I don't think the cp command there is correct. Phusion Passenger loads
native_support.so by calling "require 'phusion_passenger/native_support'", so
the file must be inside a 'phusion_passenger' directory.

== -devel subpackage

Phusion Passenger should not be split into a regular and a -devel subpackage.
We do not provide developer headers or libraries.

The source files in the ext subdirectory are not used during runtime, so they
can be safely omitted from the RPMs. The lib subdirectory however must be
present.

== test subdirectory

The test subdirectory contains unit tests and integration tests, and are only
useful for Phusion Passenger developers, not for Phusion Passenger users. You
can safely omit this subdirectory in the RPMs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.