[Bug 504430] Review Request: healpy - A python wrapper of the healpix library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504430





--- Comment #3 from Joseph Smidt <josephsmidt at gmail.com>  2009-06-07 11:53:58 EDT ---
(In reply to comment #2)
> - The BRs are incorrect.
>  BuildRequires: python
> should be
>  BuildRequires: python-devel

Sorry if I made a mistake here, but the packaging guidelines for Python state
to use python, not python-devel:
https://fedoraproject.org/wiki/Packaging/Python


> ?? The package uses BOTH python_sitearch AND python_sitelib?? (Are you building
> on x86, then these will point to the same place?)

Again, sorry if this was a mistake, this package has C/C++ libraries and the
above guidelines seem to suggest you use python_sitelib for normal Python
modules and python_sitearch for "libraries (like those written in C)".

I've never dealt with a Python program with these kind of libraries before so I
got confused.

> 
> - Why on Earth do you
>  mkdir -p %{buildroot}%{_datadir}/%{name}/
>  mv %{buildroot}%{python_sitelib}/%{name}/data
> %{buildroot}%{_datadir}/%{name}/data
> as this will probably break functionality..?
> 

Because they are just example .fits files.  However, I will put them back. 

> - As the Healpix C++ package is included in the distribution, you need to find
> a way to remove it and use healpix-c++-devel instead.  

Okay, I will do this and the other things.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.