[Bug 502525] Review Request: lazygal - static photo gallery generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=502525


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-06-07 12:40:53 EDT ---
For 0.4.1-2:

* BR (BuildRequires)
  - "BR: python-devel" instead of "BR: python" is needed
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1395448

* Documents
  - Please consider to also add the following files as %doc:
----------------------------------------------------------
ChangeLog
TODO
----------------------------------------------------------

* %changelog
  - I recommend to add one line between each %changelog
    entry (as this is useful when importing packages into
    Fedora CVS) like:
----------------------------------------------------------
* Mon May 25 2009 Byron Clark <byron at theclarkfamily.name> 0.4.1-2
- Fix typo in upstream URL.

* Sun May 24 2009 Byron Clark <byron at theclarkfamily.name> 0.4.1-1
- Initial release
----------------------------------------------------------

* Misc rpmlint issue
----------------------------------------------------------
lazygal.src: W: strange-permission lazygal-0.4.1.tar.gz 0600
lazygal.src: W: strange-permission lazygal.spec 0600
----------------------------------------------------------
  - Please change the permission of files in srpm
    to 0644.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.